Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-6261] Add Uniffi bindings for TDE #608

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[PM-6261] Add Uniffi bindings for TDE #608

merged 1 commit into from
Feb 13, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 12, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add Uniffi bindings for the TDE functionality.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia February 12, 2024 11:06
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 12, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 02349452-1ed9-43f0-92c6-b67c7156973a

No New Or Fixed Issues Found

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (2290bc8) 59.44% compared to head (7993474) 59.42%.

Files Patch % Lines
crates/bitwarden-crypto/src/uniffi_support.rs 0.00% 7 Missing ⚠️
crates/bitwarden/src/mobile/crypto.rs 22.22% 7 Missing ⚠️
crates/bitwarden-uniffi/src/auth/mod.rs 0.00% 3 Missing ⚠️
crates/bitwarden-crypto/src/keys/device_key.rs 94.11% 1 Missing ⚠️
crates/bitwarden/src/auth/client_auth.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   59.44%   59.42%   -0.03%     
==========================================
  Files         171      171              
  Lines       10324    10346      +22     
==========================================
+ Hits         6137     6148      +11     
- Misses       4187     4198      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Add Uniffi bindings for TDE [PM-6261] Add Uniffi bindings for TDE Feb 12, 2024
@Hinton Hinton merged commit d722e17 into main Feb 13, 2024
57 of 58 checks passed
@Hinton Hinton deleted the ps/tde-unlock branch February 13, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia